feat(U-Boot): add QoS configuration section#582
feat(U-Boot): add QoS configuration section#582bryanbrattlof wants to merge 2 commits intoTexasInstruments:masterfrom
Conversation
|
New issues found with check_toc_txt.py: |
|
New warnings found with rstcheck: |
792589f to
c2884e4
Compare
StaticRocket
left a comment
There was a problem hiding this comment.
Vale comments about simple language an passive voice should probably be addressed
c2884e4 to
7995b38
Compare
|
New issues found with check_toc_txt.py: |
a17be0c to
12fdf23
Compare
|
I took care of most of the Vale issues. What I scanned seems to be stuff I don't think we can fix unless I skipped over something. I also split up the file endings to a separate patch |
8c0767a to
60ec232
Compare
StaticRocket
left a comment
There was a problem hiding this comment.
There are still some lengthy sentences here that vale doesn't like. Going to let others voice opinions about that
Simple invisible character fixes Signed-off-by: Bryan Brattlof <bb@ti.com>
Add basic documentation on how the CBASS QoS blocks function and how Sysconfig can be used to generate the files for U-Boot to apply during the SoC's bootup phase. Co-authored-by: Randolph Sapp <res.sapp@gmail.com> Signed-off-by: Bryan Brattlof <bb@ti.com>
60ec232 to
06cc12a
Compare
| linux/Documentation_Tarball | ||
|
|
||
| linux/Demo_User_Guides/Chromium_Browser No newline at end of file | ||
| linux/Demo_User_Guides/Chromium_Browser |
There was a problem hiding this comment.
Doesnt belong in this patch.
There was a problem hiding this comment.
what patch are you referring? Do I need a separate PR to fix the white-space with this file before I update it?
| ====================== | ||
|
|
||
| Most transactions default to the lowest priority (ASEL 0, Order ID 0). | ||
| During boot-up, `U-Boot can update`_ these settings using data from the. |
There was a problem hiding this comment.
| During boot-up, `U-Boot can update`_ these settings using data from the. | |
| During boot-up, `U-Boot can update`_ these settings with data from the |
|
|
||
| Most transactions default to the lowest priority (ASEL 0, Order ID 0). | ||
| During boot-up, `U-Boot can update`_ these settings using data from the. | ||
| Sysconfig Tool which you can download or launch online `here`_. |
There was a problem hiding this comment.
| Sysconfig Tool which you can download or launch online `here`_. | |
| Sysconfig Tool, which you can download or use online `here`_. |
|
|
||
| The Common Bus Architecture (CBASS) module includes Quality of Service | ||
| (QoS) blocks to route and prioritize SoC bus traffic. By adjusting | ||
| attributes like priority, Address Selection (ASEL), and Order ID |
There was a problem hiding this comment.
| attributes like priority, Address Selection (ASEL), and Order ID | |
| attributes such as priority, Address Selection (ASEL), and Order ID |
| .. _U-Boot can update: https://source.denx.de/u-boot/u-boot/-/blob/v2025.10/arch/arm/mach-k3/am62px/am62p5_init.c?ref_type=tags#L253 | ||
| .. _here: https://www.ti.com/tool/SYSCONFIG | ||
|
|
||
| The MCU+ SDK documentation has `an excellent guide`_ on how to to use the |
There was a problem hiding this comment.
| The MCU+ SDK documentation has `an excellent guide`_ on how to to use the | |
| The MCU+ SDK documentation has `an excellent guide`_ on how to use the |
| .. note:: | ||
|
|
||
| Configuring the QoS blocks of a running system can cause issues. | ||
| You can only modify these settings during boot-up by the boot-loaders |
There was a problem hiding this comment.
| You can only modify these settings during boot-up by the boot-loaders | |
| You can only change these settings during boot by using the boot-loaders, |
|
|
||
| For example, most K3 SoC External Memory Interface (EMIF) controllers | ||
| use two ports. Setting an Order ID between 8 and 15 routes traffic | ||
| through a high-priority port, ensuring it is serviced before standard |
There was a problem hiding this comment.
| through a high-priority port, ensuring it is serviced before standard | |
| through a high-priority port, ensuring it gets serviced before standard |
|
No. I've had enough. This has taken me 2 months to get through the nitpicking. So long in fact the people originally asking for this documentation are no longer with TI. I will be marking this a blocked until we get a proper copy editor. I have better things to do with my time. |
|
Going to be real, you could have at least read the linter warnings 2 months ago. These nitpicks are suggestions to the same linter warnings you've had since the start of this PR. |
Add basic documentation on how the CBASS QoS blocks function and how Sysconfig can be used to generate the files for U-Boot to apply during the SoC's bootup phase.